Integration test for CPU feature detection #1186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
I accidentally committed broken CPU-feature-detection code in #1182 (fixed the next day by #1184)
This kind of accident slipped through because I was in a rush, and we don't have unit tests to double-check this particular code. Unit tests for feature detection are hard because these features vary wildly machine to machine.
Description of changes:
Add an integration test that checks CPU-feature-detection against linux's easy-to-parse
/proc/cpuinfo
.This test is skipped on platforms like Windows and Apple where there's no simple way to query CPU features
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.