Open
Conversation
…into iot_metrics
…into iot_metrics
…into iot_metrics
sfod
reviewed
Mar 30, 2026
Comment on lines
+49
to
+52
| // Indicates whether AWS IoT Metrics are enabled for this client, default to true. | ||
| // We don't expose this setting in the builder for now. | ||
| private IoTDeviceSDKMetrics iotDeviceSDKMetrics; | ||
| private boolean metricsEnabled = true; |
Contributor
There was a problem hiding this comment.
Is the "We don't expose this setting in the builder for now" part still true? There's withMetricsEnabled in Mqtt5ClientOptionsBuilder.
Contributor
Author
There was a problem hiding this comment.
We only allow user to enable/disable the metrics, but not directly make changes to the metrics. Let me update the comments to make it more clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
IoTDeviceSDKMetricsand metrics related features , CRT is now appending AWS metrics by default.enableMetricsoption to allow user disable metrics.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.