Open
Conversation
… used. We changed our internal PublishReturn constructor which required changes
bretambrose
reviewed
Mar 16, 2026
src/main/java/software/amazon/awssdk/crt/mqtt5/Mqtt5Client.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/awssdk/crt/mqtt5/PublishReturn.java
Outdated
Show resolved
Hide resolved
…heck if control was taken
bretambrose
reviewed
Mar 25, 2026
| * callback. If they did NOT, auto-invoke the PUBACK to avoid losing it. | ||
| */ | ||
| if (control_id != 0 && publish_packet_return_data != NULL) { | ||
| /* Invalidate the PublishReturn to prevent post-callback use */ |
Contributor
There was a problem hiding this comment.
Why not combine these two into a single atomic operation?
Contributor
Author
There was a problem hiding this comment.
Combining them would conflate the two functions invalidateAfterCallback and wasControlAcquired into a singular one that handles both actions when they serve two distinct and clear purposes. It would reduce JNI calls by one but what's here feels cleaner. I'd rather stick with this unless we see some kind of material performance degradation. If Vera's perf work is in place, we should be able to see if it's costly enough but in normal MQTT use I don't see it as an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind manual puback
Opaque manual puback control handle
Tests for Manual Puback
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.