Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter upgrade and fixes #793

Merged
merged 1 commit into from
Mar 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/mega-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

- name: MegaLinter
id: ml
uses: oxsecurity/megalinter@v8.1.0
uses: oxsecurity/megalinter@v8.4.2
env:
# All available variables are described in documentation
# https://megalinter.io/configuration/
Expand Down
2 changes: 2 additions & 0 deletions docs/installation-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ Please note that building on *Windows* is not supported, please use the
This should return a table that is possibly empty.
- Additionally, running `docker --version` should return version 19 or
later.
<!-- markdown-link-check-disable-next-line -->
- [make](https://www.gnu.org/software/make/)
- To test if it is available, run `make --version`.
This should return 4.3 or later.
Expand All @@ -101,6 +102,7 @@ Please note that building on *Windows* is not supported, please use the
- [jq](https://github.com/jqlang/jq)
- To test if it is available, run `jq --version`.
This version should be 1.6 or later.
<!-- markdown-link-check-disable-next-line -->
- [sed](https://www.gnu.org/software/sed/)
- To test if it is available, run `sed --version`.
This should return 4.3 or later.
Expand Down
5 changes: 5 additions & 0 deletions samples/sample-service-catalog-product/productX/template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ Parameters:
Resources:
Cloud9Instance:
Type: AWS::Cloud9::EnvironmentEC2
Metadata:
cfn-lint:
config:
ignore_checks:
- E1152
Properties:
AutomaticStopTimeMinutes: !Ref AutomaticStopTimeInMinutes
Description: !Ref InstanceDescription
Expand Down