Update schema naming strategy to allow key and value based namings #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacktooth
reviewed
Apr 7, 2021
| @@ -213,6 +213,7 @@ | |||
| <!-- Ignore exception classes --> | |||
| <exclude>**/AWSIncompatibleDataException*</exclude> | |||
| <exclude>**/AWSSchemaRegistryException*</exclude> | |||
| <exclude>**/AWSSchemaNamingStrategy*</exclude> | |||
There was a problem hiding this comment.
Why do we have to exclude this?
There was a problem hiding this comment.
Because it is in an interface and by default we don't call default methods.
There was a problem hiding this comment.
Can we test it by creating an implementation that doesn't call it?
blacktooth
approved these changes
Apr 26, 2021
| default String getSchemaName(String transportName, | ||
| Object data, | ||
| boolean isKey) { | ||
| return isKey ? getSchemaName(transportName) : getSchemaName(transportName, data); |
There was a problem hiding this comment.
So, by default data is ignored? I assume you did this for backwards compatibility, but it leads to issues discussed in #93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, #33
Description of changes: Extend customization of schema naming strategy by key and value
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.