fix: S3FileSystem configuration visibility and name update #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjschreiber
requested changes
Jan 21, 2025
sielenk-yara
force-pushed
the
fix-config-getter
branch
2 times, most recently
from
70cc18c to
5d0636f
Compare
|
Hi @sielenk-yara, let me know what the current status is with these open PR's. If there is anything you'd like me to review or merge and in any particular order, let me know. |
sielenk-yara
force-pushed
the
fix-config-getter
branch
from
026e603 to
1990aba
Compare
…me more appropriate and Kotlin friendly
sielenk-yara
force-pushed
the
fix-config-getter
branch
from
6b74308 to
696228d
Compare
|
This should be good to go, too, if you are fine with my changes. |
markjschreiber
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for issue #601.