Restructure trl/ test cases: shared base image and descriptive naming#1000
Merged
mijanur132 merged 2 commits intomainfrom Feb 27, 2026
Merged
Restructure trl/ test cases: shared base image and descriptive naming#1000mijanur132 merged 2 commits intomainfrom
mijanur132 merged 2 commits intomainfrom
Conversation
Rename grpo/ to grpo-math-reasoning/ for clarity, create a unified trl/Dockerfile with all TRL example dependencies, add a HyperPod EKS Dockerfile extension, and add a library-level README with test case table. This establishes the pattern for PR #997 and future TRL test cases to share a single base image rather than duplicating Dockerfiles.
HyperPod EKS support will be added separately when needed.
mijanur132
approved these changes
Feb 27, 2026
Collaborator
mijanur132
left a comment
mijanur132
left a comment
There was a problem hiding this comment.
Everything looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grpo/togrpo-math-reasoning/for descriptive test case namingtrl/Dockerfilewith all TRL example dependencies (shared base image)trl/README.mdwith test case table and build instructionsgrpo.Dockerfile(replaced by shared base)train.sbatchand test caseREADME.mdThis establishes the pattern for future TRL test cases to share a single base image rather than duplicating Dockerfiles.
Test plan
git log --followshows rename history for moved filesgrpo/orgrpo.Dockerfileremaintrl/Dockerfilebuilds successfullytrl-base.sqshand/grpo-math-reasoning/mount paths