Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error code and clickstream error event #37

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

zhu-xiaowei
Copy link
Contributor

@zhu-xiaowei zhu-xiaowei commented Sep 12, 2023

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. add error codes consistent with Web SDK
  2. add _clickstream_error preset event, when event name, global/user attribute is invalid.

How did you test these changes?
added test case for each error code and clickstream error event.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update), PR link

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Sep 12, 2023
@zxkane zxkane enabled auto-merge (squash) September 12, 2023 11:27
@zxkane zxkane merged commit 2b29c60 into main Sep 12, 2023
4 checks passed
@zxkane zxkane deleted the update_error_code branch September 12, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants