Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create event error when event name is invalid #42

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. create event error when event name is invalid

How did you test these changes?
added test case for record an event with invalid event name.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Sep 20, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.13% ⚠️

Comparison is base (1c006ae) 86.65% compared to head (9200bb7) 86.52%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #42      +/-   ##
============================================
- Coverage     86.65%   86.52%   -0.13%     
- Complexity      399      400       +1     
============================================
  Files            39       39              
  Lines          1446     1447       +1     
  Branches        126      127       +1     
============================================
- Hits           1253     1252       -1     
- Misses          120      122       +2     
  Partials         73       73              
Files Changed Coverage Δ
...aws/solution/clickstream/AWSClickstreamPlugin.java 83.72% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit ba43cfb into main Sep 20, 2023
4 checks passed
@zxkane zxkane deleted the fix_create_event_error branch September 20, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants