Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: engagement time in first screen view when app warm starts #44

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. fix engagement time in first screen view when app warm starts

How did you test these changes?
added test case to simulation the app warm start and verify _engagement_mesc attribute not in the first screen view event.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Sep 26, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (41ff6e1) 86.45% compared to head (94d44c4) 86.57%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #44      +/-   ##
============================================
+ Coverage     86.45%   86.57%   +0.12%     
- Complexity      402      405       +3     
============================================
  Files            39       39              
  Lines          1447     1453       +6     
  Branches        128      129       +1     
============================================
+ Hits           1251     1258       +7     
  Misses          123      123              
+ Partials         73       72       -1     
Files Coverage Δ
...solution/clickstream/ActivityLifecycleManager.java 98.03% <100.00%> (+0.16%) ⬆️
...tion/clickstream/client/AutoRecordEventClient.java 97.02% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit c1ac692 into main Sep 26, 2023
4 checks passed
@zxkane zxkane deleted the fix_warm_start branch September 26, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants