Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support adding items with custom attributes. #45

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. support adding items with custom attributes.

NOTE: This is a breaking change, only pipelines from version 1.1+ can handle items with custom attribute.

How did you test these changes?
added test case to cover all item error code.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei marked this pull request as draft October 10, 2023 13:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (5d31535) 86.94% compared to head (eb0503f) 87.17%.

Files Patch % Lines
...ws/solution/clickstream/client/AnalyticsEvent.java 71.42% 3 Missing and 3 partials ⚠️
...ware/aws/solution/clickstream/ClickstreamItem.java 83.33% 4 Missing ⚠️
...aws/solution/clickstream/AWSClickstreamPlugin.java 77.77% 0 Missing and 2 partials ⚠️
.../aws/solution/clickstream/client/EventChecker.java 98.46% 2 Missing ⚠️
...aws/solution/clickstream/ClickstreamAnalytics.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #45      +/-   ##
============================================
+ Coverage     86.94%   87.17%   +0.23%     
- Complexity      422      447      +25     
============================================
  Files            40       42       +2     
  Lines          1501     1638     +137     
  Branches        131      149      +18     
============================================
+ Hits           1305     1428     +123     
- Misses          123      133      +10     
- Partials         73       77       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review November 30, 2023 08:12
README.md Outdated Show resolved Hide resolved
@zxkane zxkane merged commit 88037a0 into main Dec 12, 2023
4 checks passed
@zxkane zxkane deleted the custom_item branch December 12, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants