Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support record screen view event manually #63

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. support record screen view event manually

How did you test these changes?
(Please add a line here how the changes were tested)
added new unit test case for verify the manually screen view events record

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5197b2a) 87.12% compared to head (39a17e1) 87.20%.

Files Patch % Lines
...aws/solution/clickstream/ClickstreamAnalytics.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #63      +/-   ##
============================================
+ Coverage     87.12%   87.20%   +0.08%     
- Complexity      446      454       +8     
============================================
  Files            42       42              
  Lines          1639     1665      +26     
  Branches        149      152       +3     
============================================
+ Hits           1428     1452      +24     
- Misses          133      135       +2     
  Partials         78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@zxkane zxkane enabled auto-merge (squash) February 20, 2024 11:29
@zxkane zxkane merged commit 5c61666 into main Feb 21, 2024
6 checks passed
@zxkane zxkane deleted the custom_screen_view branch February 21, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants