Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the second app start event's sessionId #70

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: the second app start event's sessionId #70

merged 2 commits into from
Mar 5, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. fix the second _app_start event's sessionId

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Mar 5, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane March 5, 2024 06:38
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base (f2f80fd) to head (9daa06a).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #70   +/-   ##
=========================================
  Coverage     86.49%   86.50%           
  Complexity      458      458           
=========================================
  Files            42       42           
  Lines          1688     1689    +1     
  Branches        154      153    -1     
=========================================
+ Hits           1460     1461    +1     
  Misses          150      150           
  Partials         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei changed the title fix: the second _app_start event's sessionId fix: the second app start event's sessionId Mar 5, 2024
@zhu-xiaowei zhu-xiaowei force-pushed the fix-app-start branch 2 times, most recently from abdfc43 to 7fcfbc8 Compare March 5, 2024 07:08
@zxkane zxkane merged commit ad33661 into main Mar 5, 2024
6 checks passed
@zxkane zxkane deleted the fix-app-start branch March 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants