feat(streaming-kafka-api): Reuse existing service token on MSK Kafka API #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmouhib
requested changes
Sep 10, 2024
lmouhib
requested changes
Sep 10, 2024
lmouhib
force-pushed
the
feat/kafka-api-byo-service-token
branch
from
e179cdd
to
68756bb
Compare
…ed service token in msk serverless - provisioned - api.
lmouhib
force-pushed
the
feat/kafka-api-byo-service-token
branch
from
699f11f
to
4d1f3b3
Compare
lmouhib
changed the title
lmouhib
changed the title
github-actions
bot
added
e2e-testing
lmouhib
requested changes
Sep 11, 2024
lmouhib
requested changes
Sep 11, 2024
github-actions
bot
added
e2e-completed
lmouhib
requested changes
Sep 12, 2024
…ervice token by parameters
lmouhib
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying multiple stacks with the KafkaAPI, if there is an already existing service token deployed for the custom resource, you can reuse it to reduce the number of resource created.
This will additionally reduce the numbers of IP assigned to the Lambdas (custom resources)
Description of changes:
Checklist
fix:,feat:,docs:, ...)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.