Open
Conversation
Author
|
I'm looking for feedback on this PR. I think it is ready to go. I can promote it to a full PR once I get some indication that I'm headed in the right direction. I'd like to also fix #533 but can do that as a separate PR if that is desirable. |
Adding Link to synapse install instructions.
adding instructions
Author
|
is anyone available to review this and help me get it merged? |
Contributor
|
@jasonhorner We apologize for the delay in reviewing this PR. We are available to review it and help it get merged. Can you promote it to a full PR so that the build can be run? |
Author
|
@rdsharma26 it looks like it is ready to go please advise if additional steps are need on my end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#579
Description of changes:
PatternMatchanalyzer by incorporating the following regex patterns:PatternMatchexamples and unit tests to include these new patterns for validation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.