Skip to content

Implement Features Per Issue 579#580

Open
jasonhorner wants to merge 6 commits intoawslabs:masterfrom
jasonhorner:master
Open

Implement Features Per Issue 579#580
jasonhorner wants to merge 6 commits intoawslabs:masterfrom
jasonhorner:master

Conversation

@jasonhorner
Copy link
Copy Markdown

Issue #, if available:
#579

Description of changes:

  • Added support for validating US phone numbers and US postal codes in the PatternMatch analyzer by incorporating the following regex patterns:
    1. US Phone Number Regex:
      val PHONE_NUMBER_US: Regex = """^(?:\+1\s?)?(?:\(?[2-9][0-9]{2}\)?[\s-]?)?[2-9][0-9]{2}[\s-]?[0-9]{4}(?:\s?(?:ext|x|extension)\s?[0-9]{4})?$""".r
    2. US Postal Code Regex:
      val POSTAL_CODE_US: Regex = """\b\d{5}(?:-\d{4})?\b""".r
  • Updated the PatternMatch examples and unit tests to include these new patterns for validation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jasonhorner
Copy link
Copy Markdown
Author

I'm looking for feedback on this PR. I think it is ready to go. I can promote it to a full PR once I get some indication that I'm headed in the right direction. I'd like to also fix #533 but can do that as a separate PR if that is desirable.

Adding Link to synapse install instructions.
adding instructions
@jasonhorner jasonhorner marked this pull request as ready for review September 14, 2024 19:28
@jasonhorner
Copy link
Copy Markdown
Author

is anyone available to review this and help me get it merged?

@rdsharma26 rdsharma26 requested review from rdsharma26 and removed request for rdsharma26 April 23, 2025 18:15
@rdsharma26
Copy link
Copy Markdown
Contributor

@jasonhorner We apologize for the delay in reviewing this PR. We are available to review it and help it get merged. Can you promote it to a full PR so that the build can be run?

@jasonhorner
Copy link
Copy Markdown
Author

@rdsharma26 it looks like it is ready to go please advise if additional steps are need on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants