Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AWS region & profile from kube context #383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions cmd/eks-node-viewer/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"os"
"strings"

awsSdk "github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/session"
tea "github.com/charmbracelet/bubbletea"
"k8s.io/apimachinery/pkg/labels"
Expand Down Expand Up @@ -68,7 +69,9 @@ func main() {
}
ctx, cancel := context.WithCancel(context.Background())

pprov := aws.NewStaticPricingProvider()
region, profile := client.GetAWSRegionAndProfile(flags.Kubeconfig, flags.Context)

pprov := aws.NewStaticPricingProvider(region)
style, err := model.ParseStyle(flags.Style)
if err != nil {
log.Fatalf("creating style, %s", err)
Expand All @@ -85,7 +88,13 @@ func main() {
}

if !flags.DisablePricing {
sess := session.Must(session.NewSessionWithOptions(session.Options{SharedConfigState: session.SharedConfigEnable}))
sess := session.Must(session.NewSessionWithOptions(
session.Options{
Config: awsSdk.Config{Region: &region},
Profile: profile,
SharedConfigState: session.SharedConfigEnable,
},
))
pprov = aws.NewPricingProvider(ctx, sess)
}
controller := client.NewController(cs, nodeClaimClient, m, nodeSelector, pprov)
Expand Down
8 changes: 5 additions & 3 deletions pkg/aws/pricing.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,12 @@ func getStaticPrices(region string) map[ec2types.InstanceType]float64 {
return InitialOnDemandPricesAWS["us-east-1"]
}

func NewStaticPricingProvider() nvp.Provider {
region := os.Getenv("AWS_REGION")
func NewStaticPricingProvider(region string) nvp.Provider {
if region == "" {
region = "us-east-1"
region := os.Getenv("AWS_REGION")
if region == "" {
region = "us-east-1"
}
}

return &pricingProvider{
Expand Down
44 changes: 42 additions & 2 deletions pkg/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package client
import (
"strings"

"github.com/spf13/pflag"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/client-go/kubernetes"
"k8s.io/client-go/kubernetes/scheme"
Expand Down Expand Up @@ -60,9 +61,48 @@ func NewNodeClaims(kubeconfig, context string) (*rest.RESTClient, error) {
return rest.RESTClientFor(&config)
}

func getConfig(kubeconfig, context string) (*rest.Config, error) {
func GetAWSRegionAndProfile(kubeconfig, context string) (region, profile string) {
config := getClientConfig(kubeconfig, context)
raw, err := config.RawConfig()
if err != nil {
return "", ""
}

if context == "" {
context = raw.CurrentContext
}
kubeContext := raw.Contexts[context]
if kubeContext == nil {
return "", ""
}
auth := raw.AuthInfos[kubeContext.AuthInfo]
if auth == nil || auth.Exec == nil {
return "", ""
}

// use a flagset to parse the args from the exec config
//
flagSet := pflag.NewFlagSet("aws", pflag.ContinueOnError)
flagSet.ParseErrorsWhitelist.UnknownFlags = true
regionPtr := flagSet.String("region", "", "")
_ = flagSet.Parse(auth.Exec.Args)

for _, env := range auth.Exec.Env {
if env.Name == "AWS_PROFILE" {
profile = env.Value
}
}

return *regionPtr, profile
}

func getClientConfig(kubeconfig, context string) clientcmd.ClientConfig {
// use the current context in kubeconfig
return clientcmd.NewNonInteractiveDeferredLoadingClientConfig(
&clientcmd.ClientConfigLoadingRules{Precedence: strings.Split(kubeconfig, ":")},
&clientcmd.ConfigOverrides{CurrentContext: context}).ClientConfig()
&clientcmd.ConfigOverrides{CurrentContext: context})
}

func getConfig(kubeconfig, context string) (*rest.Config, error) {
return getClientConfig(kubeconfig, context).ClientConfig()
}