Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add commitlint github action #124

Merged
merged 7 commits into from
Nov 30, 2023
Merged

feat: add commitlint github action #124

merged 7 commits into from
Nov 30, 2023

Conversation

scottschreckengaust
Copy link
Collaborator

@scottschreckengaust scottschreckengaust commented Nov 29, 2023 •
edited
Loading

add commitlint workflow

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@scottschreckengaust
feat: add commitlint github workflow
6fb9493 
Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
@scottschreckengaust
fix: checkout depth for review
79cf17d 
Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
@scottschreckengaust
fix: add commitlint configuration
2761530 
Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
github-actions and others added 3 commits November 29, 2023 23:21
chore: self mutation
d53be0b 
Signed-off-by: github-actions <github-actions@github.com>
@scottschreckengaust
fix: merge conflict
fd92050 
Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
chore: self mutation
c642c31 
Signed-off-by: github-actions <github-actions@github.com>
@scottschreckengaust scottschreckengaust marked this pull request as ready for review November 30, 2023 00:15
@scottschreckengaust scottschreckengaust requested a review from a team as a code owner November 30, 2023 00:15
@scottschreckengaust scottschreckengaust enabled auto-merge (squash) November 30, 2023 00:16
MichaelWalker-git
MichaelWalker-git approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottschreckengaust scottschreckengaust merged commit 5f9c7e6 into main Nov 30, 2023
14 checks passed
@scottschreckengaust scottschreckengaust deleted the feature/commitlint-action branch November 30, 2023 14:18
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krokoko krokoko krokoko approved these changes

@MichaelWalker-git MichaelWalker-git MichaelWalker-git approved these changes

@hvital hvital Awaiting requested review from hvital hvital is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

@laithalsaadoon laithalsaadoon Awaiting requested review from laithalsaadoon laithalsaadoon is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

@dineshSajwan dineshSajwan Awaiting requested review from dineshSajwan dineshSajwan is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

Assignees
No one assigned
Labels
admired-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottschreckengaust @krokoko @MichaelWalker-git @emerging-tech-cdk-constructs-bot