feat: implement opensearch serverless support #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 93.91% 93.82% -0.09%
==========================================
Files 18 19 +1
Lines 5654 5766 +112
Branches 136 152 +16
==========================================
+ Hits 5310 5410 +100
- Misses 344 356 +12 ☔ View full report in Codecov by Sentry. |
|
|
||
| beforeAll(() => { | ||
| const ragTestStack = new cdk.Stack(undefined, undefined, { | ||
| env: { account: cdk.Aws.ACCOUNT_ID, region: cdk.Aws.REGION }, |
There was a problem hiding this comment.
Is it possible for this to be a snapshot instead from a mocked or fictitious account and region?
hvital
force-pushed
the
feature/add-existingOpensearchServerlessCollection
branch
from
72b4111 to
63db8b2
Compare
hvital
requested review from
krokoko,
laithalsaadoon,
MichaelWalker-git and
dineshSajwan
hvital
force-pushed
the
feature/add-existingOpensearchServerlessCollection
branch
from
f5b95cb to
469a305
Compare
scottschreckengaust
approved these changes
Jan 25, 2024
hvital
force-pushed
the
feature/add-existingOpensearchServerlessCollection
branch
from
469a305 to
dd4c5d3
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 136
This PR adds an existingOpensearchServerlessCollection option to support importing existing OpenSearch Serverless collections.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.