Fix for issue where git-secrets could fail on Windows if enough files… #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… where modified to be over the 32727 command line length
When git-secrets is run, for all filepaths that are part of the staged list of changes they get passed into an invocation of `git grep`
If there is a large number of staged files, depending on the length of each file path from the git repo root, it could result in an extremely long line being supplied to `git grep`
For example if the git structure is as below
```
/
Include/
TestLibrary/
MyTestComponent1.h
MyTestComponent2.h
...
MyTestComponent1000.h
```
It would take around changes to 900 "Include/TestLibrary/MyTestComponentNNNN.h` files within the repo to cause the `git grep` to be passed an argument list that is too long
This allows filenames with spaces to be properly parsed as a single file when invoking `git grep`
|
Any updates for reviewers on this PR |
|
#153 is a more robust solution to this problem. If we don't merge that, we can re-open this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… where modified to be over the 32727 command line length
When git-secrets is run, for all filepaths that are part of the staged list of changes they get passed into an invocation of
git grepIf there is a large number of staged files, depending on the length of each file path from the git repo root, it could result in an extremely long line being supplied to
git grepFor example if the git structure is as below
It would take around changes to 900
Include/TestLibrary/MyTestComponentNNNN.hfiles within the repo to cause thegit grepto be passed an argument list that is too longIssue #192, if available:
Description of changes:
Fixed issue where git secrets could fail if the bash invocation of
git grepwithin the git-secrets shell script passed enough file paths that caused the command line invocation forgit grepto be over 32767 charactersBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.