Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid scanning of entire repo when a file is deleted #253

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

khhipparagi
Copy link

Issue #, if available:

The git secrets scan the entire repo when the file is removed. For large repos, this impacts the user experience, if they are using any IDE for development, developers need to use the terminal to force git secrets to skip the scan with --no-verify option.

Description of changes:

This change is done when no files are returned, and then pre_commit_hook will gracefully return instead of calling scan_with_fn_or_die function.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wtfiwtz
Copy link

wtfiwtz commented Jun 14, 2024

This was merged in khhipparagi#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants