Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource-binding): Create a file with a security group ID #147

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

faymard
Copy link

@faymard faymard commented Feb 14, 2025

Create a file with a security group ID when it is defined as AccessSecurityGroupId in the resource manifest

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

Resource binding currently supports adding IAM statements to application roles so they can execute AWS API operations on a given resource.

My goal is to also make it possible to bind a given security group (provided in a resource manifest via the appData.AccessSecurityGroupId) which would give networking access to the resource from the application.

The file created in the application's .iac directory would then be read by the CDK stack to add said security group to the ECS service/EKS pod security group policy.

For Moderators

  • Compile, build, tests successful before merge?

Additional Notes

@faymard faymard force-pushed the feat-bind-security-group branch from af19df8 to b32ba9e Compare February 18, 2025 09:11
…t is defined as AccessSecurityGroupId in the resource manifest
@faymard faymard force-pushed the feat-bind-security-group branch from b32ba9e to b7c8867 Compare February 19, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant