fix(dashboard): state fixes for dynamic assets tab #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corteggiano
reviewed
Sep 26, 2024
| @@ -19,6 +19,7 @@ export interface AssetExplorerProps { | |||
| selectedWidgets: DashboardWidget[]; | |||
| timeZone?: string; | |||
| significantDigits?: number; | |||
| correctSelectionMode: 'single' | 'multi'; | |||
There was a problem hiding this comment.
is this a public API update or just internal?
There was a problem hiding this comment.
This one is internal. Its the props for all the RE tables in dashboard to manage dashboard state changes (ie selected widget/clicking Add or Reset). Just forgot to add in this one to the dynamic asset tab when I was doing the RE work.
corteggiano
reviewed
Sep 26, 2024
...yEditor/iotSiteWiseQueryEditor/assetModelDataStreamExplorer/assetModelDataStreamExplorer.tsx
Outdated
Show resolved
Hide resolved
corteggiano
reviewed
Sep 26, 2024
...yEditor/iotSiteWiseQueryEditor/assetModelDataStreamExplorer/assetModelDataStreamExplorer.tsx
Show resolved
Hide resolved
corteggiano
reviewed
Sep 26, 2024
...yEditor/iotSiteWiseQueryEditor/assetModelDataStreamExplorer/getAssetModelQueryInformation.ts
Outdated
Show resolved
Hide resolved
corteggiano
reviewed
Sep 26, 2024
| fetchAll: true, | ||
| }); | ||
|
|
||
| const currentSelectedAsset = assetSummaries.find( |
There was a problem hiding this comment.
will assetSummaries ever be undefined?
There was a problem hiding this comment.
no, but in case there is no assets retrieved, currentSelectedAsset will be undefined which has handling in the query editors.
There was a problem hiding this comment.
unless the query errors out
ssjagad
force-pushed
the
improve-asset-model-tab
branch
4 times, most recently
from
bbf4926
to
6eb0071
Compare
ssjagad
force-pushed
the
improve-asset-model-tab
branch
from
6eb0071
to
9b58848
Compare
corteggiano
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix for screen jumping to top when selecting dashboard model properties. To fix, removed useState call and moved selectedAsset state up to parent QueryEditor component.
In doing so found the following bugs and fixed them as well.
Asset Model RE keeps state of old selected asset properties after changing asset
Asset Properties table does not change selection mode based on widget type
Asset Model Tab breaks if you add duplicate properties after edit/preview change
Verifying Changes
Screen.Recording.2024-09-25.at.6.37.25.PM.mov
Legal
This project is available under the Apache 2.0 License.