feat(alarms): integrate alarms into KPI widget #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corteggiano
force-pushed
the
alarms-kpi
branch
11 times, most recently
from
782e39c
to
95c2dde
Compare
corteggiano
force-pushed
the
alarms-kpi
branch
from
95c2dde
to
d9e1171
Compare
tracy-french
approved these changes
Sep 27, 2024
|
|
||
| let borderBottom = '1px dashed '; | ||
|
|
||
| switch (state) { |
There was a problem hiding this comment.
I like how things are grouped. It's a great way to prevent bugs. I would suggest you consider how you can avoid the duplication and the mutation. I can see how someone could easily introduce a bug here by changing something on accident or forgetting to keep consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding alarm to dashboard:
alarmKPIDashboard.mov
Default states:
With thresholds and custom background colors
With data quality:
Dark mode:
Legal
This project is available under the Apache 2.0 License.