fix(viewports): format relative viewports properly #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corteggiano
force-pushed
the
fix-viewport-savve
branch
from
2a9b263
to
1053666
Compare
corteggiano
force-pushed
the
fix-viewport-savve
branch
from
1053666
to
775e3c5
Compare
corteggiano
changed the title
mumanity
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Before: Relative viewports were being saved as
5 minute3 week1 yearthis did not align with the dashboard save functionality
After: Relative viewports are in the format
30s5m1hany relative viewports in days, weeks, months, and years are converted to their appropriate hours
formatViewports.mov
Legal
This project is available under the Apache 2.0 License.