Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): fix HDR loader in react example #3038

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

haweston
Copy link
Contributor

Overview

Attempting to use the react example app as a stand alone app base can result in the HDR files form scene composer not loading and breaking at run time under vite.

To make using the example be a better starting point for new appliation development adding stand alone vite support for HDR files to the default vite.config.ts settings.

Verifying Changes

Runs when built inside iot-app-kit.
If examples/react-app is copied to it's own folder and npm install and npm run start are run on it as a stand alone application the vite server should not through any errors about not having a loader for hdr files.

Scene Composer

For scene-composer package changes specifically, you can preview the component in the published storybook artifact. To do this, wait for the Publish Storybook action to complete below.

  • Click on the workflow details
  • Select the Summary item on the left
  • Download the zip file

To run the storybook build locally, you need a local static web server:

npm install -g httpserver
cd <Extracted Zip Directory>
httpserver

Then open the website http://localhost:8080 to run the doc site.

Legal

This project is available under the Apache 2.0 License.

@haweston haweston merged commit 63afb47 into main Oct 10, 2024
20 checks passed
@haweston haweston deleted the viteExampleHdr branch October 10, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants