-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(customizations): add support for operational preferences when creating stacksets #579
Open
allcloud-sahar-hagbi
wants to merge
12
commits into
awslabs:main
Choose a base branch
from
allcloud-sahar-hagbi:feat/add-support-operational-preferences
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Control Tower environment
Export operational preferences option when deploying custom stacksets
Adding some fixes for operatinal preferences option
mbevc1
approved these changes
Sep 29, 2024
hi @erwaxler, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Following our meeting (AWS LZA's team & AllCloud), here is one of the feature requests we discussed there.
The feature request is to control the
operational preferences
option when deploying stacksets in customization-config.yaml.Right now, there is no option to control that option, and default values are supplied:
operationPreferences: { failureTolerancePercentage: 25, maxConcurrentPercentage: 35, regionConcurrencyType: 'PARALLEL', }
I exported the
operational preferences
property to be controlled by the user as an input along with the other properties that are not mentioned above:failureToleranceCount, maxConcurrentCount, regionOrder
Those are all the options for the operational preferences property.
It is important to say that I left the default values as it was before, which won't have any affect on any users using the solution.