Fix bind command-line argument being ignored (#1020)

* Fix bind argument being ignored Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com> * Fix bad changelog message Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com> --------- Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
awslabs · Sep 19, 2024 · 321a19f · 321a19f
1 parent f430895
commit 321a19f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/mountpoint-s3/CHANGELOG.md b/mountpoint-s3/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### Other changes
 
 * Add AWS ISO partitions to STS credential provider. ([awslabs/aws-c-auth#253](https://github.com/awslabs/aws-c-auth/pull/253))
+* Fix an issue where `--bind` argument would not be picked up correctly. ([#1020](https://github.com/awslabs/mountpoint-s3/pull/1020))
 
 ## v1.9.0
 

diff --git a/mountpoint-s3/Cargo.toml b/mountpoint-s3/Cargo.toml
@@ -81,7 +81,6 @@ built = { version = "0.7.1", features = ["git2"] }
 [features]
 # Unreleased feature flags
 event_log = []
-multiple-nw-iface = []
 # Features for choosing tests
 fips_tests = []
 fuse_tests = []

diff --git a/mountpoint-s3/src/cli.rs b/mountpoint-s3/src/cli.rs
@@ -642,7 +642,6 @@ pub fn create_s3_client(args: &CliArgs) -> anyhow::Result<(S3CrtClient, EventLoo
     if let Some(ttl) = args.metadata_ttl {
         user_agent.key_value("mp-cache-ttl", &ttl.to_string());
     }
-    #[cfg(feature = "multiple-nw-iface")]
     if let Some(interfaces) = &args.bind {
         user_agent.key_value("mp-nw-interfaces", &interfaces.len().to_string());
     }
@@ -667,7 +666,6 @@ pub fn create_s3_client(args: &CliArgs) -> anyhow::Result<(S3CrtClient, EventLoo
         .read_backpressure(true)
         .initial_read_window(initial_read_window_size)
         .user_agent(user_agent);
-    #[cfg(feature = "multiple-nw-iface")]
     if let Some(interfaces) = &args.bind {
         client_config = client_config.network_interface_names(interfaces.clone());
     }