-
Notifications
You must be signed in to change notification settings - Fork 164
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add memory usage check to the CI (#1028)
* Check resource utilization Signed-off-by: Monthon Klongklaew <monthonk@amazon.com> * PR comments Signed-off-by: Monthon Klongklaew <monthonk@amazon.com> --------- Signed-off-by: Monthon Klongklaew <monthonk@amazon.com>
- Loading branch information
Showing
6 changed files
with
142 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| //! A helper binary for parsing Mountpoint logs and collecting metrics. | ||
| //! Currently, we are only interested in peak memory usage from `process.memory_usage`. | ||
| //! | ||
| //! This binary is intended only for use in testing and development of Mountpoint. | ||
|
|
||
| use std::{ | ||
| fs::{self, File}, | ||
| io::{BufRead, BufReader, BufWriter, Write}, | ||
| path::PathBuf, | ||
| }; | ||
|
|
||
| use anyhow::anyhow; | ||
| use clap::Parser; | ||
| use regex::Regex; | ||
| use serde_json::json; | ||
|
|
||
| #[derive(Parser, Debug)] | ||
| struct CliArgs { | ||
| #[clap(help = "Log directory to analyze", value_name = "LOG_DIRECTORY")] | ||
| log_dir: PathBuf, | ||
|
|
||
| #[clap(help = "Output JSON file name", value_name = "OUTPUT_FILE")] | ||
| out_file: PathBuf, | ||
|
|
||
| #[clap(help = "Test name to be reported in JSON file")] | ||
| test_name: String, | ||
| } | ||
|
|
||
| fn main() -> anyhow::Result<()> { | ||
| const MEM_USAGE_LOG_PATTERN: &str = "process\\.memory_usage:\\s\\d+$"; | ||
|
|
||
| let args = CliArgs::parse(); | ||
| let paths = fs::read_dir(args.log_dir)?; | ||
| let log_pattern = Regex::new(MEM_USAGE_LOG_PATTERN)?; | ||
|
|
||
| let mut metric_values: Vec<u64> = Vec::new(); | ||
|
|
||
| // collect metrics from all log files in the given directory | ||
| for path in paths { | ||
| let path = path?; | ||
| let file_type = path.file_type()?; | ||
| if file_type.is_file() { | ||
| let file = File::open(path.path())?; | ||
| let reader = BufReader::new(file); | ||
|
|
||
| for line in reader.lines() { | ||
| if line.is_err() { | ||
| continue; | ||
| } | ||
| let line = line.unwrap(); | ||
| if log_pattern.is_match(&line) { | ||
| let iter = line.split_whitespace(); | ||
| if let Some(parsed_result) = iter.last().map(|last| last.parse::<u64>()) { | ||
| let Ok(value) = parsed_result else { | ||
| return Err(anyhow!("Unable to parse metric value: {}", parsed_result.unwrap_err())); | ||
| }; | ||
| metric_values.push(value); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| let max = if let Some(value) = metric_values.iter().max() { | ||
| *value as f64 / (1024 * 1024) as f64 | ||
| } else { | ||
| 0.0 | ||
| }; | ||
| let contents = json!({ | ||
| "name": args.test_name, | ||
| "value": max, | ||
| "unit": "MiB", | ||
| }); | ||
| let file = File::create(args.out_file)?; | ||
| let mut writer = BufWriter::new(file); | ||
| serde_json::to_writer(&mut writer, &contents)?; | ||
| writer.flush()?; | ||
| Ok(()) | ||
| } |
5d5e0acThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2.time_to_first_byte_read82.6637304milliseconds32.5779172milliseconds2.54This comment was automatically generated by workflow using github-action-benchmark.