Skip to content

Commit

Permalink
Fix resource utilization check in the CI
Browse files Browse the repository at this point in the history
Our CI workflows work by checking out the code from branch `gh-pages` to
retrieve benchmark results from previous commits and compare them to values
in the current run. However, the resource utilization check was done
after the benchmark result check which already has pulled in the branch
`gh-pages` resulting in errors because the branch already exists. This
change fixes that.

Signed-off-by: Monthon Klongklaew <monthonk@amazon.com>
  • Loading branch information
monthonk committed Sep 25, 2024
1 parent f92bf6c commit 7d65bb2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ jobs:
auto-push: ${{ inputs.publish }}
comment-on-alert: true
max-items-in-chart: 20
skip-fetch-gh-pages: true

latency-bench:
name: Benchmark (Latency)
Expand Down Expand Up @@ -218,3 +219,4 @@ jobs:
auto-push: ${{ inputs.publish }}
comment-on-alert: true
max-items-in-chart: 20
skip-fetch-gh-pages: true
1 change: 1 addition & 0 deletions .github/workflows/bench_s3express.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ jobs:
auto-push: ${{ inputs.publish }}
comment-on-alert: true
max-items-in-chart: 20
skip-fetch-gh-pages: true

latency-bench:
name: Benchmark (Latency)
Expand Down

0 comments on commit 7d65bb2

Please sign in to comment.