Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix dependency from 0.27.1 to 0.29.0 #1003

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

dannycjones
Copy link
Contributor

Description of change

For a change I'm working on, I'd like to use some new APIs in nix. They aren't available in 0.27.1.

There's been a few breaking changes in nix (for the better), so there's some code changes to review here.

Relevant issues: N/A

Does this change impact existing behavior?

No.

Does this change need a changelog entry in any of the crates?

No, no behavior change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannycjones dannycjones added this pull request to the merge queue Sep 6, 2024
Merged via the queue into awslabs:main with commit 6d49885 Sep 6, 2024
23 checks passed
@dannycjones dannycjones deleted the update-nix branch September 6, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants