Make cache writes async #1029
Merged
Make cache writes async #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passaro
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
passaro
force-pushed
the
cache-write-async
branch
from
245f5b6
to
4ff1f8a
Compare
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
passaro
force-pushed
the
cache-write-async
branch
from
5adb639
to
ea34668
Compare
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Spawn separate tasks to update cache blocks, rather than writing synchronously and blocking the read path.
Does this change impact existing behavior?
No
Does this change need a changelog entry in any of the crates?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).