Add new 'mock' feature for 'mock-mount-s3' binary #1030
Merged
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Without this change, we get a compilation error due to missing dependencies:
This change adds a new
mock
feature to themountpoint-s3
crate, which implies bothmountpoint-s3-client/mock
andfutures/thread-pool
. We mark themock-mount-s3
client as requiring themock
feature, so building will fail as follows:By building with the feature enabled, building completes.
Relevant issues: #1018
Does this change impact existing behavior?
It changes the features required to build the
mock-mount-s3
binary. This is not stable.Does this change need a changelog entry in any of the crates?
No, this is not customer facing behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).