Update CRT submodules to latest releases #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Burak Varlı <burakvar@amazon.co.uk>
unexge
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
IsaevIlya
previously approved these changes
Oct 17, 2024
CRT was returning error during first operation before if it provided with a non-existent network interface name. But with awslabs/aws-c-s3#456, it started failing during the client creation phase. Our tests were written for the previous behaviour and was expecting client creation to succeed even with an invalid network interface. The test is updated to expect errors during client creation. Signed-off-by: Burak Varlı <burakvar@amazon.co.uk>
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
IsaevIlya
previously approved these changes
Oct 17, 2024
monthonk
requested changes
Oct 17, 2024
Co-authored-by: Monthon Klongklaew <monthonk@amazon.com> Signed-off-by: Burak <unexge@gmail.com>
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Notably, includes awslabs/aws-c-s3#457.
Size:
$ cargo package -p mountpoint-s3-crt-sys --no-verify --allow-dirty Packaging mountpoint-s3-crt-sys v0.9.0 (~/Code/mountpoint-s3/mountpoint-s3-crt-sys) Packaged 2132 files, 38.3MiB (6.8MiB compressed)CRT changelog:
Does this change impact existing behavior?
No breaking changes,
aws-c-s3now retries onRequestTimeoutfrom S3.Does this change need a changelog entry in any of the crates?
Yes, updated.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).