Update macOS unit tests to use latest macOS #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
unexge
approved these changes
Nov 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
<!-- The title and description of pull requests will be used when creating a squash commit to the base branch (usually `main`). Please keep them both up-to-date as the code change evolves, to ensure that the commit message is useful for future readers. --> ## Description of change This change adds the architecture of the runner to the cache key. In a previous change where we upgraded macOS runners from macOS 12 to macOS 15, the architecture changed however the cache was not invalidated. Likely we should find a way to key the cache on the actual operating system version used however there doesn't seem to be an obvious way to do that right now. This quick fix should at least protect us from architecture changes (which macOS runners do have, but I understand its only for larger runners at this time). Relevant issues: #1097 ## Does this change impact existing behavior? No, only CI change. ## Does this change need a changelog entry in any of the crates? No, only CI change. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change updates the CI to use the latest version of macOS available on GitHub runners (currently macOS 15), updating from macOS 12.
We are seeing GitHub CI failing in some cases. We wanted to update version anyway, and I suspect the issues we are seeing is due to the deprecation (maybe).
I update to latest since we don't strictly support macOS, so just checking that unit tests pass on the latest version is enough for us.
Relevant issues:
Does this change impact existing behavior?
CI change only. No behavior change.
Does this change need a changelog entry in any of the crates?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).