Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bounding ball calculation for coaxial lumped ports #246

Merged
merged 11 commits into from
May 9, 2024
Merged

Fix bounding ball calculation for coaxial lumped ports #246

merged 11 commits into from
May 9, 2024

Commits on May 7, 2024

  1. Fix bounding ball calculation for coaxial lumped ports

    @sebastiangrimberg
    sebastiangrimberg committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b2da4ca View commit details
    Browse the repository at this point in the history

  2. Remove BoundingBall and replace use in coaxial lumped ports with Boun… 

    …dingBox
    @sebastiangrimberg
    sebastiangrimberg committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7ba4f14 View commit details
    Browse the repository at this point in the history

  3. Fix bounding box for non-rectangular boundaries

    @sebastiangrimberg
    sebastiangrimberg committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c22bf04 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Restore GetBoundingBall calculation which uses Welzl's algorithm

    @sebastiangrimberg
    sebastiangrimberg committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d6a869f View commit details
    Browse the repository at this point in the history

  2. Improve implementation for minumum bounding ball, test 3D case

    @sebastiangrimberg
    sebastiangrimberg committed May 8, 2024
    Configuration menu
    Copy the full SHA
    70de55e View commit details
    Browse the repository at this point in the history

  3. Remove debugging code

    @sebastiangrimberg
    sebastiangrimberg committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f98872d View commit details
    Browse the repository at this point in the history

  4. Remove unneeded include

    @sebastiangrimberg
    sebastiangrimberg committed May 8, 2024
    Configuration menu
    Copy the full SHA
    78e2de9 View commit details
    Browse the repository at this point in the history

  5. Address PR feedback and improve initialization for Welzl

    @sebastiangrimberg
    sebastiangrimberg committed May 8, 2024
    Configuration menu
    Copy the full SHA
    32ebd0c View commit details
    Browse the repository at this point in the history

  6. Silence uninitialized variable warning

    @sebastiangrimberg
    sebastiangrimberg committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c82393e View commit details
    Browse the repository at this point in the history

  7. Revise typo in comment

    @sebastiangrimberg
    sebastiangrimberg committed May 8, 2024
    Configuration menu
    Copy the full SHA
    cfc317e View commit details
    Browse the repository at this point in the history

  8. Update changelog

    @sebastiangrimberg
    sebastiangrimberg committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d4c52bd View commit details
    Browse the repository at this point in the history