Fix divergence cleaning when a model has no real boundaries #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple a structure which has only periodic boundaries
LeilaGhaffari
added a commit
to LeilaGhaffari/palace-lg
that referenced
this pull request
Jun 25, 2024
hughcars
reviewed
Jun 26, 2024
palace/linalg/divfree.cpp
Outdated
Comment on lines
69
to
70
| MPI_Comm_split(comm, color, Mpi::Rank(comm), &split_comm); | ||
| if (split_comm != MPI_COMM_NULL && Mpi::Root(split_comm)) |
There was a problem hiding this comment.
So there's only one dof on each processor with more than one dof correct?
There was a problem hiding this comment.
Yeah this was a silly overcomplication, thanks for pointing this out. Simplified in ee3dbd7.
LeilaGhaffari
added a commit
to LeilaGhaffari/palace-lg
that referenced
this pull request
Jul 3, 2024
Original/Duplicate pair for periodic boundary No need for div free operator after awslabs#269: it doesn't fail when it is triply periodic but it cannot handle partially periodic meshes
LeilaGhaffari
added a commit
to LeilaGhaffari/palace-lg
that referenced
this pull request
Jul 22, 2024
Original/Duplicate pair for periodic boundary No need for div free operator after awslabs#269: it doesn't fail when it is triply periodic but it cannot handle partially periodic meshes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids solving a singular Laplace problem when calculating the scalar potential for a model with no real boundaries. For example, this can be observed by printing the output of divergence-free projection linear solve for the cavity example with PMC boundaries. After this PR, the divergence-free solves actually converge normally in a few iterations and the eigensolve converges as well.
Correctly handles the case of some subdomains having potentially no true dofs and just enforces a potential = 0 on the processor of lowest rank with some non-zero number of local true dofs.