Improve enum parsing from JSON #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiangrimberg
force-pushed
the
sjg/json-enum-parsing
branch
from
e07a0c7
to
eb7efec
Compare
hughcars
approved these changes
Aug 21, 2023
sebastiangrimberg
force-pushed
the
hughcars/lumped-port-orientation-dev
branch
from
f632ee9
to
b9c26d7
Compare
sebastiangrimberg
force-pushed
the
sjg/json-enum-parsing
branch
from
eb7efec
to
0d04e7b
Compare
sebastiangrimberg
force-pushed
the
sjg/json-enum-parsing
branch
from
0d04e7b
to
40eb45a
Compare
… and eliminate need for INVALID enums throughout the code
sebastiangrimberg
force-pushed
the
sjg/json-enum-parsing
branch
from
40eb45a
to
56f22d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously every enum defined in
configfile.hpphad a*_INVALIDoption because the behavior of theNLOHMANN_JSON_SERIALIZE_ENUMmacro'sfrom_jsonwas to assign to the first enum in the list if no matching value was found in the provided map. This PR writes adds a customfrom_jsonfunction which throws an error in this case, since this was always what we wanted to do, and allows us to remove these extraneous*_INVALIDenum options from the code.