Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snap build #16

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix snap build #16

merged 1 commit into from
Sep 13, 2024

Conversation

toabctl
Copy link
Contributor

@toabctl toabctl commented Aug 30, 2024

Commit ec1eab1 renamed the executable so reflect this rename in the snap build, too.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@agraf
Copy link
Contributor

agraf commented Aug 30, 2024

@toabctl Thanks for the patch! Would you mind to sign it so I can merge?

@toabctl toabctl force-pushed the main-fix-snap branch 2 times, most recently from 6d54a15 to 7697ace Compare August 30, 2024 11:43
@toabctl
Copy link
Contributor Author

toabctl commented Sep 13, 2024

@agraf signed.

@agraf
Copy link
Contributor

agraf commented Sep 13, 2024

@toabctl Github still complains:

The email in this signature doesn’t match the committer email.

Commit ec1eab1 renamed the executable so reflect this rename in
the snap build, too.
@toabctl
Copy link
Contributor Author

toabctl commented Sep 13, 2024

@agraf solved. sorry

@agraf agraf merged commit 60b9542 into awslabs:main Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants