Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check existence of tenant before updating #11

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

suhussai
Copy link
Contributor

@suhussai suhussai commented Mar 11, 2024

Issue # (if applicable)

Closes #8

Reason for this change

Description of changes

Check if tenant id exists before updating the tenant.

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@suhussai suhussai force-pushed the bug/fix-tenant-delete branch from a5b5002 to 4a3683d Compare March 27, 2024 22:46
@suhussai suhussai requested a review from tobuck-aws March 27, 2024 22:54
Copy link
Contributor

@tobuck-aws tobuck-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works, thanks Syed!

@suhussai suhussai merged commit 2dd5fbd into main Mar 27, 2024
5 checks passed
@suhussai suhussai deleted the bug/fix-tenant-delete branch March 27, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ControlPlane-TenantManagement-TenantDelete: Accepts tenant ids that don't exist
2 participants