Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add selfSignUpEnabled option to CognitoAuth for user pool configuration #127

Closed
wants to merge 1 commit into from

Conversation

KennyDizi
Copy link

@KennyDizi KennyDizi commented Jan 3, 2025

PR Type

Feature, Enhancement


PR Description

  • Added selfSignUpEnabled option to CognitoAuthProps interface.

  • Integrated selfSignUpEnabled into Cognito user pool configuration.

  • Default value for selfSignUpEnabled set to false.

  • Enhanced flexibility for user pool self-signup configuration.

Checklist

  • My code adheres to the CONTRIBUTING GUIDE
  • I have updated the relevant documentation (if applicable).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@KennyDizi KennyDizi changed the title Add selfSignUpEnabled option for CognitoAuth Add selfSignUpEnabled option to CognitoAuth for user pool configuration Jan 3, 2025
@KennyDizi
Copy link
Author

🥦 🌵 I have revised the PR description to reflect the changes made to the latest commit (87b6e1b).

@KennyDizi KennyDizi changed the title Add selfSignUpEnabled option to CognitoAuth for user pool configuration feat: Add selfSignUpEnabled option to CognitoAuth for user pool configuration Jan 3, 2025
@tobuck-aws
Copy link
Contributor

tobuck-aws commented Jan 13, 2025

@KennyDizi , first off, thanks for the contribution!

Re: the PR, I'm curious as a SaaS provider when you'd ever want your users to be able to self-signup? Given that users in this user pool typically have admin-access over the whole SaaS application, I would think we'd want to err on the side of too restrictive, vs. too permissive.

Is this more for demo-ability, given that SBT can be used as an educational aid?

@suhussai any comments here?

@suhussai
Copy link
Contributor

@KennyDizi , first off, thanks for the contribution!

Re: the PR, I'm curious as a SaaS provider when you'd ever want your users to be able to self-signup? Given that users in this user pool typically have admin-access over the whole SaaS application, I would think we'd want to err on the side of too restrictive, vs. too permissive.

Is this more for demo-ability, given that SBT can be used as an educational aid?

@suhussai any comments here?

Totally agree. @KennyDizi , if you can share what you're trying to do, perhaps we can come up with a different solution.

@KennyDizi
Copy link
Author

I got miss understanding @tobuck-aws @suhussai I will close this PR.

@KennyDizi KennyDizi closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants