Skip to content

docs: modified contribution instructions. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

docs: modified contribution instructions. #76

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e036c35
Modified contribution instructions. Fixing the path of the js files
Jul 19, 2024
3edbcd6
docs: path was correct. just added the npm install step
Jul 19, 2024
b1caef6
changed back to lib
Jul 19, 2024
8b22bf6
Merge branch 'main' into cells
suhussai Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ Please consult the issues and discussions section of the SBT repo for good first
1. Make sure existing (and new) tests pass successfully by running `npm run test`
1. Run `npm run build` to compile
1. Go to the root of the project. Then, deploy the CDK stack using the following:
- For `core-app-plane`: `npx cdk deploy --app='./lib/core-app-plane/integ.default.js'`
- For `control-plane`: `CDK_PARAM_SYSTEM_ADMIN_EMAIL="test@example.com" npx cdk deploy --app='./lib/control-plane/integ.default.js'`
- For `core-app-plane`: `npx cdk deploy --app='./src/core-app-plane/integ.default.js'`
- For `control-plane`: `CDK_PARAM_SYSTEM_ADMIN_EMAIL="test@example.com" npx cdk deploy --app='./src/control-plane/integ.default.js'`
1. Test out the new feature(s) and redeploy as needed
1. Write tests for any changed code and commit
1. Create a PR.
Expand Down
Loading