Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper pathing for nagsuppression of cdk-managed resources #90

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

suhussai
Copy link
Contributor

@suhussai suhussai commented Aug 28, 2024

Issue # (if applicable)

Closes #84

Reason for this change

Fix NagSuppression issue when using SBT in pipeline stage.

Description of changes

Use findChild() function to get the proper path of the resource instead of hardcoding it based on resource ID.

Description of how you validated changes

Replicated the template outlined in #84 and made sure the error was resolved.

Checklist

  • My code adheres to the CONTRIBUTING GUIDE
  • I have updated the relevant documentation (if applicable).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link
Contributor

@tobuck-aws tobuck-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't love adding control flow logic to deal with linters, I think we should get this out and come up with a larger strategy later.

@suhussai suhussai merged commit f1240d2 into main Aug 30, 2024
8 checks passed
@suhussai suhussai deleted the issue-84 branch August 30, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdk nag suppression error in cdk pipelines
2 participants