Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

92 allow specifying secret arns #158

Merged
merged 14 commits into from
Dec 7, 2023
Merged

Conversation

ChrisPates
Copy link
Contributor

@ChrisPates ChrisPates commented Dec 7, 2023

Issue #, if available:
#92

Description of changes:
Provides Deployment options to allow for various scenarios, including:

  • secrets & app (the default and historic behavior),
  • secrets only (same account) allows for app upgrades without changing the secrets
  • app only (same account) allows for app upgrades without changing the secrets
  • secrets for cross account (requires additional resource policies and KMS customer key)
  • app for cross account (requires additional IAM permissions)

If you already have a KMS Customer Key and Secrets deployed manually, they could be adopted into a stack or by replication the configuration line then just the app stack could be deployed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ChrisPates ChrisPates linked an issue Dec 7, 2023 that may be closed by this pull request
Adding support for using existing secrets and for the creation of a secrets only dpeloyment.
fixing regex issues
- Correcting regex issues
- Removed NoEcho from field available in the UI.
- Improved parameter validation
- enhanced descriptions including whether optional.
Major rework of parameter validation and additions to support cross-account deployment.
pinning go.lang tool versions.
@ChrisPates ChrisPates force-pushed the 92-allow-specifying-secret-arns branch from 9e98b55 to 3b27683 Compare December 7, 2023 09:40
@ChrisPates ChrisPates self-assigned this Dec 7, 2023
@ChrisPates
Copy link
Contributor Author

Merging feature.

@ChrisPates ChrisPates merged commit f5f11c9 into master Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying secret ARNs
1 participant