Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretsManagerAutoConfiguration should have AwsAutoConfiguration in AutoConfigureAfter #1232

Closed
marcindabrowski opened this issue Sep 24, 2024 · 2 comments · Fixed by #1235
Closed

Comments

@marcindabrowski
Copy link
Contributor

Type: Bug

Component: Secrets Manager

Describe the bug
In version 3.2.0 SecretsManagerAutoConfiguration was added that requires bean AwsClientBuilderConfigurer, but SecretsManagerAutoConfiguration didn't added AwsAutoConfiguration in AutoConfigureAfter but relies on CredentialsProviderAutoConfiguration and RegionProviderAutoConfiguration but do not relies on AwsCredentialsProvider and AwsRegionProvider beans.

I think that @AutoConfigureAfter({ CredentialsProviderAutoConfiguration.class, RegionProviderAutoConfiguration.class }) should be added to AwsAutoConfiguration, and AwsAutoConfiguration should be put as prerequisite for SecretsManagerAutoConfiguration.

Sample
When trying to start app with secret manager I'm getting:
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'secretsManagerClient' defined in class path resource [io/awspring/cloud/autoconfigure/config/secretsmanager/SecretsManagerAutoConfiguration.class]: Unsatisfied dependency expressed through method 'secretsManagerClient' parameter 1: No qualifying bean of type 'io.awspring.cloud.autoconfigure.core.AwsClientBuilderConfigurer' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {}

@maciejwalkowiak
Copy link
Contributor

Thanks for reporting. Would you like to send a PR with fix?

marcindabrowski added a commit to marcindabrowski/spring-cloud-aws that referenced this issue Sep 26, 2024
marcindabrowski added a commit to marcindabrowski/spring-cloud-aws that referenced this issue Sep 26, 2024
marcindabrowski added a commit to marcindabrowski/spring-cloud-aws that referenced this issue Sep 26, 2024
marcindabrowski added a commit to marcindabrowski/spring-cloud-aws that referenced this issue Sep 26, 2024
marcindabrowski added a commit to marcindabrowski/spring-cloud-aws that referenced this issue Sep 26, 2024
@marcindabrowski
Copy link
Contributor Author

created a PR #1235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants