-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SecretsManagerAutoConfiguration should have AwsAutoConfiguration in AutoConfigureAfter #1232
Comments
Thanks for reporting. Would you like to send a PR with fix? |
9 tasks
marcindabrowski
added a commit
to marcindabrowski/spring-cloud-aws
that referenced
this issue
Sep 26, 2024
marcindabrowski
added a commit
to marcindabrowski/spring-cloud-aws
that referenced
this issue
Sep 26, 2024
marcindabrowski
added a commit
to marcindabrowski/spring-cloud-aws
that referenced
this issue
Sep 26, 2024
9 tasks
marcindabrowski
added a commit
to marcindabrowski/spring-cloud-aws
that referenced
this issue
Sep 26, 2024
marcindabrowski
added a commit
to marcindabrowski/spring-cloud-aws
that referenced
this issue
Sep 26, 2024
created a PR #1235 |
maciejwalkowiak
pushed a commit
that referenced
this issue
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type: Bug
Component: Secrets Manager
Describe the bug
In version 3.2.0
SecretsManagerAutoConfiguration
was added that requires beanAwsClientBuilderConfigurer
, butSecretsManagerAutoConfiguration
didn't addedAwsAutoConfiguration
inAutoConfigureAfter
but relies onCredentialsProviderAutoConfiguration
andRegionProviderAutoConfiguration
but do not relies onAwsCredentialsProvider
andAwsRegionProvider
beans.I think that
@AutoConfigureAfter({ CredentialsProviderAutoConfiguration.class, RegionProviderAutoConfiguration.class })
should be added toAwsAutoConfiguration
, andAwsAutoConfiguration
should be put as prerequisite forSecretsManagerAutoConfiguration
.Sample
When trying to start app with secret manager I'm getting:
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'secretsManagerClient' defined in class path resource [io/awspring/cloud/autoconfigure/config/secretsmanager/SecretsManagerAutoConfiguration.class]: Unsatisfied dependency expressed through method 'secretsManagerClient' parameter 1: No qualifying bean of type 'io.awspring.cloud.autoconfigure.core.AwsClientBuilderConfigurer' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {}
The text was updated successfully, but these errors were encountered: