Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AutoConfigureAfter for SecretsManagerAutoConfiguration #1235

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

marcindabrowski
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes #1232
In version 3.2.0 SecretsManagerAutoConfiguration was added that requires bean AwsClientBuilderConfigurer, but SecretsManagerAutoConfiguration didn't added AwsAutoConfiguration in AutoConfigureAfter instead of CredentialsProviderAutoConfiguration and RegionProviderAutoConfiguration.

💡 Motivation and Context

@AutoConfigureAfter({ CredentialsProviderAutoConfiguration.class, RegionProviderAutoConfiguration.class }) was added to AwsAutoConfiguration, and AwsAutoConfiguration was put as prerequisite for SecretsManagerAutoConfiguration.

💚 How did you test it?

Added AwsAutoConfigurationTests file.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@maciejwalkowiak maciejwalkowiak added this to the 3.3.0 milestone Sep 26, 2024
@maciejwalkowiak maciejwalkowiak merged commit c6a99ad into awspring:main Sep 26, 2024
4 checks passed
@maciejwalkowiak
Copy link
Contributor

Thanks @marcindabrowski !

@marcindabrowski marcindabrowski deleted the feat/GH-1232 branch September 27, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Core functionality related issue component: secrets-manager Secrets Manager integration related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecretsManagerAutoConfiguration should have AwsAutoConfiguration in AutoConfigureAfter
2 participants