Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SES configurationSetName is configurable via properties Fixes gh-1006 #1007

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

thomas-burko
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Ability to specify the configuration set name when sending emails.

💡 Motivation and Context

#1006

💚 How did you test it?

Extended the current implementation and tested it in my environment.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added component: ses SES integration related issue type: documentation Documentation or Samples related issue labels Jan 2, 2024
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomas-burko! @MatejNedic would you like a take a look too?

Copy link
Member

@MatejNedic MatejNedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejwalkowiak maciejwalkowiak added this to the 3.1.2 milestone Jan 4, 2024
@maciejwalkowiak maciejwalkowiak merged commit ba11ee2 into awspring:main Jan 4, 2024
4 checks passed
@maciejwalkowiak maciejwalkowiak modified the milestones: 3.1.2, 3.1.1 Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ses SES integration related issue type: documentation Documentation or Samples related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants