Introduce Client side S3EncryptionClient #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: s3
MatejNedic
requested review from
maciejwalkowiak and
tomazfernandes
as code owners
|
+1 here. I see value as right now I think I'm blocked on using SSE-C in multipart uploads to a bucket. |
|
@MatejNedic can you resolve the conflicts? This looks like an important feature. I know I need it. |
|
Hey @timothystone-knsl , since I am not sure when release will be have to sync with other Maintainers. Will try to push this feature till then, you can define this as S3Client Bean on your own and it should work. Since S3AutoConfiguration should check if there is S3Client bean already existing. |
|
@maciejwalkowiak for me it is must to make user handle how he wants to store RSA or AES keys since it is security issue. This is why they need to provide implementation. KMS integration is straight forward. I would like to have this in 3.1.2. if you agree will add docs |
# Conflicts: # spring-cloud-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/s3/S3AutoConfiguration.java # spring-cloud-aws-autoconfigure/src/test/java/io/awspring/cloud/autoconfigure/s3/S3AutoConfigurationTests.java # spring-cloud-aws-dependencies/pom.xml
...-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/s3/S3AutoConfiguration.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
type: documentation
# Conflicts: # spring-cloud-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/s3/S3AutoConfiguration.java # spring-cloud-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/s3/properties/S3Properties.java # spring-cloud-aws-autoconfigure/src/test/java/io/awspring/cloud/autoconfigure/s3/S3AutoConfigurationTests.java # spring-cloud-aws-dependencies/pom.xml
MatejNedic
commented
Oct 10, 2024
...-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/s3/S3AutoConfiguration.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
component: cloudwatch
maciejwalkowiak
requested changes
Oct 30, 2024
...-cloud-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/s3/S3AesProvider.java
Show resolved
Hide resolved
...-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/s3/S3AutoConfiguration.java
Show resolved
Hide resolved
github-actions
bot
removed
component: cloudwatch
...-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/s3/S3AutoConfiguration.java
Outdated
Show resolved
Hide resolved
maciejwalkowiak
approved these changes
Nov 5, 2024
# Conflicts: # spring-cloud-aws-dependencies/pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps