Add extra message for SQS exceptions in QueueAttributesResolver #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseiedo
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
|
It looks good to me. @tomazfernandes any concerns? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Checks in QueueAttributesResolver.wrapException if the upcoming exception is an SqsException. If true, it adds a message suggesting the user check their credentials, network, and configuration.
💡 Motivation and Context
Solves #1149
The current message has caused some confusion regarding errors related to SQS, leading some users to mistakenly think that the QueueAttributesResolver class was the issue.
💚 How did you test it?
I ran a test that throws a QueueDoesNotExistException and examined the stack trace.
📝 Checklist
🔮 Next steps
Check if this new message is good enough :)
(And if its the right place to make this change)