Remove throws IOException that is never thrown in S3Resource methods
#1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can facilitate the implementation of Comparator based on contentLength or lastModified
alexisgra
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
maciejwalkowiak
approved these changes
Sep 19, 2024
maciejwalkowiak
changed the title
throws IOException that is never thrown in S3Resource methods
|
@alexisgra thanks for quick PR and no worries about formatting in SNS, i'll do it in a separate change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fix #1108
💡 Motivation and Context
I want to use
contentLengthorlastModifiedmetadata ofS3Resourceto sort list of resources, but I need to catch IOException in the comparator.IOException are declared but never thrown (it comes from parent class
AbstractResource).@maciejwalkowiak I think several classes in sns project need to be formatted. I can add them to the PR if you want.
💚 How did you test it?
x
📝 Checklist
🔮 Next steps