Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the capitalization of property for S3EncryptionConditional.KmsKeyProperty #1337

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

gbaso
Copy link
Contributor

@gbaso gbaso commented Feb 3, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Changes the capitalization of the property for S3EncryptionConditional.KmsKeyProperty from spring.cloud.aws.s3.encryption.keyId to spring.cloud.aws.s3.encryption.key-id. Adds a test that verifies the creation of an S3EncryptionClient when setting that property.

💡 Motivation and Context

Fixes gh-1333

💚 How did you test it?

Unit tests, manual tests with a sample application.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: s3 S3 integration related issue label Feb 3, 2025
@maciejwalkowiak maciejwalkowiak added this to the 3.3.1 milestone Feb 4, 2025
@maciejwalkowiak
Copy link
Contributor

Thanks @gbaso!

@maciejwalkowiak maciejwalkowiak merged commit e30abe3 into awspring:main Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: s3 S3 integration related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 KMS condition has incorrect capitalization
2 participants